Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(examples): Update examples with groups in slices #203

Merged
merged 2 commits into from
May 17, 2024
Merged

doc(examples): Update examples with groups in slices #203

merged 2 commits into from
May 17, 2024

Conversation

xrutayisire
Copy link
Contributor

@xrutayisire xrutayisire commented May 17, 2024 •
edited
Loading

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Completes DT-2082
  • Updated examples to use SharedSlice
  • Updated examples to use a Group instead of the items property for a ShareSlice

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

size-limit report 📦

Path Size
./dist/index.cjs 8.03 KB (0%)
./dist/index.js 6.05 KB (0%)
./dist/react-server.cjs 7.23 KB (0%)
./dist/react-server.js 5.58 KB (0%)

angeloashmore
angeloashmore approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙂 I left two suggestions below. It's good to merge after you consider them. 👍

examples/with-typescript/index.tsx Outdated Show resolved Hide resolved
examples/with-typescript/index.tsx Outdated Show resolved Hide resolved
@xrutayisire xrutayisire merged commit 9ab1725 into master May 17, 2024
1 check passed
@angeloashmore angeloashmore deleted the xru/update-examples-with-groups-in-slices branch May 17, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloashmore angeloashmore angeloashmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrutayisire @angeloashmore