-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prevent infinite refreshes and exiting race condition #97
feat: prevent infinite refreshes and exiting race condition #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, will test!
Can you review too @arnaudlewis?
Awesome! Here's a repo to test the issue: https://github.com/angeloashmore/prismic-toolbar-issue-66-repro |
Hello, do you have a date for merge/release this pull request? 🙏 |
Hey there, it should be released this week 👌 |
Hi, just wondering if this is still planned for this/next week? We're currently blocked by this, and it comes at a crucial time where our client is evaluating CMS platforms 😅 |
Hey there, First of all, I'm sorry for the extra delay, back and forth, and lack of visibility that has been going on with this pull request. I synced with our DevOps team this morning about it, they scheduled it for Monday morning. If it doesn't happen then, I'll make sure to sync with them again to have it shipped. Thank you for your understanding 🙏 |
This PR has been deployed, thanks for your patience! 🎉 Let us know if you encounter the issue again 🙏 |
@lihbr Thanks for the release! |
Yes, the toolbar is automatically updated for everyone. If you check the network tab you should see |
This PR addresses two related issues:
These issues are resolved by treating the preview state from the prismic.io iframe as the source of truth.
This has the nice side-effect of exiting previews across all windows at once from a single toolbar "X" click.
Reproduction to test PR
This repo can be used as a test: https://github.com/angeloashmore/prismic-toolbar-issue-66-repro