Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support link text #72

Merged
merged 5 commits into from
Sep 27, 2024
Merged

feat: support link text #72

merged 5 commits into from
Sep 27, 2024

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Aug 28, 2024 •
edited
Loading

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Let's wait for client stable release before merging 🙏

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

xrutayisire
xrutayisire approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@xrutayisire xrutayisire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM of course! Thank you so much for the PR!
We can take over as soon as we do the release process, to merge it and release a new version of the package.

@lihbr lihbr mentioned this pull request Sep 16, 2024
Merged
7 tasks
@dani-mp dani-mp merged commit 976064d into master Sep 27, 2024
16 checks passed
@dani-mp dani-mp deleted the lh/support-link-text branch September 27, 2024 12:10
@dani-mp dani-mp mentioned this pull request Sep 27, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrutayisire xrutayisire xrutayisire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lihbr @xrutayisire @dani-mp