Bring (py)Chiquito in

[gnart33]

Resolve #82

• Add scr/python.rs contains Python Module
• frontend/python/chiquito is home for python-source
• dependencies = ["py_ecc"] included in pyproject.toml so users don't have to pip install py_ecc
• add fibonacci.py to examples

[qwang98]

This is also to confirm with @leolara, but my understanding is that Chiquito Python code (non examples) should be in src/frontend/python/chiquito rather than frontend/python/chiquito? Then pychiquito.rs and maturin bindings in python.rs in this branch should go into src/frontend/python.

[qwang98]

Entirely cosmetic but we typically add one empty line to end of file.

[gnart33]

cosmetic haha

[leolara]

Actually, in some edge cases it can lead to unnecessary git conflicts when several people changes the last lines of the file. So we have this rule of always ending all files with an empty line

[qwang98]

Thanks for adding this!

Are "install chiquito with pip" and "build from source" considered two different methods for installation or two steps of installation?

To confirm, after pip install chiquito, is rust_chiquito directly accessible from chiquito.rust_chiquito or requires maturin develop? My guess is the latter.

[gnart33]

It's either to install, pip package will be available for python user, maturin develop is only for who want to build from source/develop.
Will make it clear

[qwang98]

Note that I've updated the example in the PyChiquito repo, but we can focus on getting the structure working before porting over the latest PyChiquito updates.

[qwang98]

Note to self: there are also some python comments that I should delete once we have this merged.

[qwang98]

Again, my understanding is that this file plus pychiquito.rs should go into src/frontend/python/mod.rs

[leolara]

Yes, that is the spec of the task, if that is possible, i would like it to be there

[gnart33]

Let wait for Leo to reach the agreement for the structure then I will reorg accordingly.

[leolara]

the content of frontend/pychiquito.rs together with this PR src/pyton.rs should be in frontend/python/mod.rs

[leolara]

This is also to confirm with @leolara, but my understanding is that Chiquito Python code (non examples) should be in src/frontend/python/chiquito rather than frontend/python/chiquito? Then pychiquito.rs and maturin bindings in python.rs in this branch should go into src/frontend/python.

Yes, when I have said frontend/python, I meant src/frontend/python

[leolara]

It was my mistake, I put it wrong in the issue, I have corrected it now.

[qwang98]

FYI, we should also add a tutorial folder that contains all the Jupyter files.

[leolara]

FYI, we should also add a tutorial folder that contains all the Jupyter files.

👍

[gnart33]

Dont merge yet but please see how it look

[leolara]

@trangnv we usually let the contributor to merge once approved

[leolara]

@trangnv I think it is missing:

• move src/frontend/pychiquito.rs content to src/frontend/python/mod.rs ; src/frontend/pychiquito.rs should be removed
• move jupyter tutorials
• Perhaps add a make build that builds the rust and the python

[leolara]

Excellent!!

[leolara]

@trangnv It is approved, merge it please

[gnart33]

@trangnv It is approved, merge it please

👍