Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: user sdk #2064

Merged
merged 2 commits into from
Jan 24, 2025
Merged

refactor: user sdk #2064

merged 2 commits into from
Jan 24, 2025

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 23, 2025

Description

Refactor user functions from the SDK

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@ctrlc03 ctrlc03 self-assigned this Jan 23, 2025
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jan 24, 2025 3:53pm

@ctrlc03 ctrlc03 changed the title Refactor/user sdk refactor: user sdk Jan 23, 2025
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just few comments.
And is this PR supposed to move tests?
It will be nice to have tests for sdk.

packages/sdk/package.json Outdated Show resolved Hide resolved
packages/sdk/ts/user.ts Outdated Show resolved Hide resolved
packages/sdk/ts/utils/user.ts Outdated Show resolved Hide resolved
packages/sdk/ts/utils/user.ts Outdated Show resolved Hide resolved
packages/sdk/ts/utils/user.ts Outdated Show resolved Hide resolved
packages/sdk/ts/utils/verifiers.ts Outdated Show resolved Hide resolved
packages/sdk/ts/verify.ts Outdated Show resolved Hide resolved
packages/sdk/ts/verify.ts Outdated Show resolved Hide resolved
packages/sdk/ts/verify.ts Outdated Show resolved Hide resolved
@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 24, 2025

@ctrlc03 thanks, just few comments. And is this PR supposed to move tests? It will be nice to have tests for sdk.

was thinking we could move them in a separate PR

@0xmad
Copy link
Collaborator

0xmad commented Jan 24, 2025

I think, yes, it works.

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 enabled auto-merge (squash) January 24, 2025 15:59
@ctrlc03 ctrlc03 merged commit aac1ce7 into dev Jan 24, 2025
23 checks passed
@ctrlc03 ctrlc03 deleted the refactor/user-sdk branch January 24, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants