Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: verifying keys sdk #2070

Merged
merged 1 commit into from
Jan 29, 2025
Merged

refactor: verifying keys sdk #2070

merged 1 commit into from
Jan 29, 2025

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 27, 2025

Description

Refactor functions related to verifying keys

Related issue(s)

re #1981

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jan 29, 2025 6:51pm

@ctrlc03 ctrlc03 self-assigned this Jan 27, 2025
@ctrlc03 ctrlc03 mentioned this pull request Jan 27, 2025
2 tasks
@ctrlc03 ctrlc03 force-pushed the refactor/vk branch 2 times, most recently from a322430 to 1757707 Compare January 27, 2025 23:37
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just left some minor comments

packages/sdk/ts/utils/interfaces.ts Outdated Show resolved Hide resolved
packages/sdk/ts/utils/utils.ts Show resolved Hide resolved
packages/cli/ts/commands/checkVerifyingKeys.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 merged commit 44c9e1e into dev Jan 29, 2025
23 checks passed
@ctrlc03 ctrlc03 deleted the refactor/vk branch January 29, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants