-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mpz-garble): fix threading breaking changes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e797cf7
to
2204bbd
Compare
ebd6bb5
to
f4403e2
Compare
th4s
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
themighty1
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!!! just one concern about feed vs send
Co-authored-by: dan <[email protected]>
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* refactor(mpz-garble): fix threading breaking changes * Update crates/mpz-garble/src/protocol/deap/vm.rs Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* refactor(mpz-garble): fix threading breaking changes * Update crates/mpz-garble/src/protocol/deap/vm.rs Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
mpz-garble
to accomodate the breaking changes from #112 .Changes
Context
abstraction.DEAPVm
type and just useDEAPThread