Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mpz-garble): fix threading breaking changes #144

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

sinui0
Copy link
Collaborator

@sinui0 sinui0 commented May 29, 2024

This PR refactors mpz-garble to accomodate the breaking changes from #112 .

Changes

@sinui0 sinui0 force-pushed the refactor/fix-mpz-garble-2 branch 2 times, most recently from e797cf7 to 2204bbd Compare May 30, 2024 19:45
@sinui0 sinui0 requested review from th4s and themighty1 May 30, 2024 19:47
@sinui0 sinui0 marked this pull request as ready for review May 30, 2024 19:47
Base automatically changed from feat/scoped-macro to threading-refactor May 31, 2024 13:36
@sinui0 sinui0 force-pushed the refactor/fix-mpz-garble-2 branch from ebd6bb5 to f4403e2 Compare May 31, 2024 13:40
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!!! just one concern about feed vs send

crates/mpz-garble/src/generator/mod.rs Show resolved Hide resolved
crates/mpz-garble/src/protocol/deap/vm.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 merged commit e4128a2 into threading-refactor Jun 5, 2024
@sinui0 sinui0 deleted the refactor/fix-mpz-garble-2 branch June 5, 2024 16:37
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(mpz-garble): fix threading breaking changes

* Update crates/mpz-garble/src/protocol/deap/vm.rs

Co-authored-by: dan <[email protected]>

---------

Co-authored-by: dan <[email protected]>
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(mpz-garble): fix threading breaking changes

* Update crates/mpz-garble/src/protocol/deap/vm.rs

Co-authored-by: dan <[email protected]>

---------

Co-authored-by: dan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants