refactor: decouple assignment from definition #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@th4s sry I had to make a couple changes after finding issues integrating with tlsn |
Co-authored-by: dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples assignment of values from the definition of values, and is the first step needed to support pre-garbling circuits in the offline phase.
Changes
PrimitiveTypetrait inmpz-circuitsto help statically distinguish between array values and primitives.ValueRegistryandEncodingRegistrytoValueMemoryandEncodingMemoryMemorytrait methods, introducingassign.ValueConfigandValueIdConfigstructsValueIdandValueRefintompz-garblefrommpz-coreArrayReftype which is a variant ofValueRefwhich enforces some invariants which simplifies logic everywhere.Generator,EvaluatorandDEAPto accomodate these changes.