Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port/hypernova multifolding #10

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Port/hypernova multifolding #10

merged 2 commits into from
Sep 11, 2023

Conversation

arnaucube
Copy link
Collaborator

@arnaucube arnaucube commented Aug 25, 2023

Port HyperNova's multifolding impl that we did with @asn-d6 at https://github.com/privacy-scaling-explorations/multifolding-poc , adapting and refactoring some of its methods and structs.

Note: adapted mle.rs methods from dense to sparse repr.

@arnaucube arnaucube marked this pull request as draft August 25, 2023 17:23
@arnaucube arnaucube marked this pull request as ready for review August 29, 2023 09:53
@arnaucube arnaucube requested a review from han0110 August 29, 2023 09:53
@arnaucube arnaucube marked this pull request as draft September 1, 2023 23:02
@arnaucube
Copy link
Collaborator Author

Update: since in the PR #11 there are some changes that affect this PR, marking this PR as draft until #11 is merged, then I'll rebase this PR to main and mark it ready for review.

@arnaucube arnaucube force-pushed the port/hypernova-multifolding branch 3 times, most recently from 57f002a to 46307ef Compare September 6, 2023 18:27
@arnaucube arnaucube marked this pull request as ready for review September 7, 2023 05:45
@arnaucube
Copy link
Collaborator Author

Update: this branch has been rebased to latest main after last PRs, so this PR is now ready for review.

Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ported this exact code to Microsoft/Nova so I already stated all the things months ago. Since this code is the exact same one I've already deeply reviewed.

I'll simply approve.

arnaucube and others added 2 commits September 7, 2023 19:27
…-explorations/multifolding-poc adapting and refactoring some of its methods and structs.

Note: adapted mle.rs methods from dense to sparse repr.

Co-authored-by: George Kadianakis <[email protected]>
HyperNova nimfs: move CCS structure outside of LCCCS & CCCS, to avoid
carrying around the whole CCS and duplicating data when is not needed.

Also add feature flags for the folding schemes.
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnaucube arnaucube added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 8256c27 Sep 11, 2023
3 checks passed
@arnaucube arnaucube deleted the port/hypernova-multifolding branch November 7, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants