-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port/hypernova multifolding #10
Conversation
e15bfe2
to
6ef9adc
Compare
5fd57e2
to
512c32b
Compare
57f002a
to
46307ef
Compare
Update: this branch has been rebased to latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ported this exact code to Microsoft/Nova so I already stated all the things months ago. Since this code is the exact same one I've already deeply reviewed.
I'll simply approve.
…-explorations/multifolding-poc adapting and refactoring some of its methods and structs. Note: adapted mle.rs methods from dense to sparse repr. Co-authored-by: George Kadianakis <[email protected]>
HyperNova nimfs: move CCS structure outside of LCCCS & CCCS, to avoid carrying around the whole CCS and duplicating data when is not needed. Also add feature flags for the folding schemes.
46307ef
to
b2c2f3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Port HyperNova's multifolding impl that we did with @asn-d6 at https://github.com/privacy-scaling-explorations/multifolding-poc , adapting and refactoring some of its methods and structs.
Note: adapted mle.rs methods from dense to sparse repr.