Improve the design of circuit, config, and instances for CycleFold #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values will be used as hints to the augmented circuit
…simplify the construction of incoming CF instances
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #123. Before #123 gets merged, a diff can be found here: winderica:protogalaxy-based-ivc...winderica:refactor-cyclefold.
This PR aims to refactor the existing code related to CycleFold improve the design. Specifically, it:
cf_u.xinto a separate function. Before this PR,cf_u.xis manually constructed by concatenating randomness and points in all augmented circuits of Nova, HyperNova, and ProtoGalaxy, as observed in Protogalaxy based IVC #123 (comment).