This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Documentation Improvements in ZK-EVM Specs #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' to 'written to the data source'
ChihChengLiang
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Hi @joaolago1113,
Your updated description of push_data_left is clearer.
Thank you for improving this part of the doc.
ChihChengLiang
merged commit c45d517
into
privacy-scaling-explorations:master
1 check passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request includes several updates to the ZK-EVM specifications documentation. The main change is in
bytecode-proof.md, where the definition ofpush_data_lefthas been made clearer. Previously, the description read, "The number of left bytes data needs to be PUSHed," which was somewhat incomprehensible. Other minor grammar and clarity fixes are included in different parts of the documentation.Commits:
push_data_leftfor better clarity.opcode/5AGAS.md.copy-proof.md.evm-proof.md.Request for Review:
I've updated the definition of
push_data_leftto make it easier to understand as I found hard to interpret. It'd be great if you could check this part to ensure it aligns well with the technical aspects of the ZK-EVM.