UI improvements #303
Merged
UI improvements #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
w-ensink
commented
Nov 28, 2024
•
w-ensink
commented
- Raise the navigation bar on newer iOS devices with rounded displays (Give navigation bar some more padding on the bottom on iOS #301)
- Improve icons in navigation bar to be filled in when selected and outlined otherwise
- Add visual feedback when pressing on buttons and cards (Add visual feedback to some buttons in Yivi app #297)
- Remove padding around dividers to improve list item height consistency
- Add always scrollable behavior to list views so they don't become static with few items
- Made background color more consistent between pages
- Allow swipe to go back to any page transition where it makes sense (Enable swipe to go back on iOS #302)
- Correct ellipsis button hit target for data cards
- add allways scrollable physics to the data page for more natural feel on iOS
- add always scrollable physics - add splash on buttons presses
- used the same blue color as the main screens for a more consistent look - add always scrollable physics to more pages for more natural feel
- now shows outline when tab is not selected for home and data tabs
- check if the app is running on a newer iOS device by looking at the aspect ratio
- it was just ever so slightly to high compared to the other nav bar text
- update deprecated WillPopScope to PopScope
- is required by flutter analyze
- on data card
- was calling a bloc function on every render, when it should only be called when the user tries to pop a page and it fails
ivard
approved these changes
Nov 29, 2024
DibranMulder
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.