generated from privacycg/template
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let document.hasStorageAccess
check whether the Document already has unpartitioned data access
#174
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5555beb
Check whether the context already has unpartitioned data access in hSA
shuranhuang d5efb4d
Add implementation dfn of "whether the user agent allows unpartitione…
shuranhuang de02b69
Queue a global task for the algo
shuranhuang 9191bee
Address comments
shuranhuang 88d169e
Update inline algo definition
shuranhuang 95261cc
Update the "user agent explicitly allows..." part
shuranhuang a8a08cc
Use (topLevelSite, embeddedSite) tuple for user agent's setting checks.
shuranhuang 259ede3
Update storage-access.bs
shuranhuang 2c68690
Update storage-access.bs
shuranhuang 5140c14
Update storage-access.bs
shuranhuang 971c279
Add non-normative note for user decission.
shuranhuang 7a88f3e
Update storage-access.bs
shuranhuang bd288a1
Update storage-access.bs
shuranhuang 9637c1c
Update storage-access.bs
shuranhuang a390040
Update storage-access.bs
shuranhuang f3aaccb
Update storage-access.bs
shuranhuang 8f5dda8
Inline the sub step
shuranhuang 4ad7a32
format string
shuranhuang 10030f4
Remove early return for top-level document and same authority cases
shuranhuang 3ef5060
Add back top-level and same authority checks and make sure they are c…
shuranhuang 024f4b8
Resolve comments
shuranhuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this better. Does @johannhof agree with this change as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this still LGTM :)