Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new "Hardware" section #2594

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Create new "Hardware" section #2594

merged 1 commit into from
Jun 1, 2024

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented May 30, 2024 •
edited
Loading

Changes proposed in this PR:

  • Move security keys to separate page
  • Add Yubico Security Keys
    • These were already an implied recommendation given that we tell people to use Yubico's quiz to find the right product, but this just splits apart the recommendation into two sections so that we can explain both separately. Plus we can order these security keys first because I think that most people will be fine with FIDO2 functionality only.

partial changes from #2592

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

jonaharagon added a commit that referenced this pull request May 30, 2024
@jonaharagon
Create new "Hardware" section (#2594)
f5df6e2
@jonaharagon jonaharagon force-pushed the jonaharagon/security-keys-changes branch from 36f2983 to f5df6e2 Compare May 30, 2024 11:10
jonaharagon added a commit that referenced this pull request May 30, 2024
@jonaharagon
Create new "Hardware" section (#2594)
8d80671
@jonaharagon jonaharagon force-pushed the jonaharagon/security-keys-changes branch from f5df6e2 to 8d80671 Compare May 30, 2024 11:12
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 166a90b
😎 Preview https://2594--glowing-salamander-8d7127.netlify.app/

redoomed1
redoomed1 requested changes May 30, 2024
View reviewed changes
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the suggestions below, I have another trivial suggestion not related to the content in the PR: modifying the PR title to differentiate this PR from #2268 (or vice versa).

docs/basics/passwords-overview.md Outdated Show resolved Hide resolved
docs/multi-factor-authentication.md Outdated Show resolved Hide resolved
@redoomed1
Copy link
Member

Also, thoughts on moving the Google Pixel recommendation to this new section (in a different page, of course)? It is currently housed in a section titled "Android Devices", and there is already separate criteria for Android devices. (This change would happen in a separate PR and require that this PR be merged first.)

@friadev
Copy link
Contributor

friadev commented May 30, 2024

Also, thoughts on moving the Google Pixel recommendation to this new section (in a different page, of course)? It is currently housed in a section titled "Android Devices", and there is already separate criteria for Android devices. (This change would happen in a separate PR and require that this PR be merged first.)

Yes that would be awesome

@jonaharagon
Copy link
Member Author

I think that this PR will be merged before #2268 so that one will have to be refactored and renamed, but I'll do that after this one is merged.

I think a Mobile Phone page in this new section is a good idea.

@dngray
Copy link
Member

dngray commented May 31, 2024 •
edited
Loading

I think that this PR will be merged before #2268 so that one will have to be refactored and renamed, but I'll do that after this one is merged.

Certainly, this change makes a lot of sense as these pages were getting quite long.

@dngray dngray added c:enhancements new features or other enhancements to the website itself c:hardware relating to hardware recommendations labels May 31, 2024
jonaharagon added a commit that referenced this pull request May 31, 2024
@jonaharagon
update: Create new "Hardware" section (#2594)
166a90b 
Signed-off-by: Daniel Gray <[email protected]>
@jonaharagon jonaharagon force-pushed the jonaharagon/security-keys-changes branch from c815c85 to 166a90b Compare May 31, 2024 08:25
redoomed1
redoomed1 approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging this PR also closes #2551.

@jonaharagon jonaharagon force-pushed the jonaharagon/security-keys-changes branch from 166a90b to 44f3558 Compare June 1, 2024 05:52
@jonaharagon jonaharagon merged commit 44f3558 into main Jun 1, 2024
6 of 7 checks passed
@jonaharagon jonaharagon deleted the jonaharagon/security-keys-changes branch June 1, 2024 05:52
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-06-01/18648/1

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/remove-nitrokey/18567/35

@redoomed1 redoomed1 mentioned this pull request Jun 2, 2024
Closed
2 tasks
@redoomed1 redoomed1 mentioned this pull request Jun 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redoomed1 redoomed1 redoomed1 approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:enhancements new features or other enhancements to the website itself c:hardware relating to hardware recommendations
Projects
PR Review Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaharagon @redoomed1 @friadev @dngray @privacyguides-bot