[BA] Setup participant skeletons for the B&A demo #411
Conversation
kevinkiklee
force-pushed
the
setup-ba-participants
branch
from
309af99 to
6d09857
Compare
kevinkiklee
changed the title
kevinkiklee
force-pushed
the
setup-ba-participants
branch
from
6d09857 to
06d810f
Compare
kevinkiklee
changed the title
kevinkiklee
changed the title
[BA] Setup B&A demo loading mechanism
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| async (req: Request, res: Response) => { | ||
| const {useCaseName} = req.params; | ||
| const title = 'DSP X - Join Ad Interest Group'; | ||
| res.render(`uc-${useCaseName}/join-ad-interest-group`, { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
There was a problem hiding this comment.
Do we need the use case name to be a user provided value? I think it would be better to replace this with uc-ba for now since this is the only use case relevant for DSP X and Y
| async (req: Request, res: Response) => { | ||
| const {useCaseName} = req.params; | ||
| const title = 'DSP Y - Join Ad Interest Group'; | ||
| res.render(`uc-${useCaseName}/join-ad-interest-group`, { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| app.get('/uc-:useCaseName', async (req: Request, res: Response) => { | ||
| const {useCaseName} = req.params; | ||
|
|
||
| res.render(`uc-${useCaseName}`, { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| async (req: Request, res: Response) => { | ||
| const {useCaseName} = req.params; | ||
| const title = 'DSP X - Join Ad Interest Group'; | ||
| res.render(`uc-${useCaseName}/join-ad-interest-group`, { |
There was a problem hiding this comment.
Do we need the use case name to be a user provided value? I think it would be better to replace this with uc-ba for now since this is the only use case relevant for DSP X and Y
| async (req: Request, res: Response) => { | ||
| const {useCaseName} = req.params; | ||
| const title = 'DSP Y - Join Ad Interest Group'; | ||
| res.render(`uc-${useCaseName}/join-ad-interest-group`, { |
| function buildBaInterestGroup(useCaseName: string, advertiser: string) { | ||
| const imageCreative = new URL(`${DSP_Y_ORIGIN}ads`); | ||
| const biddingLogicUrl = new URL( | ||
| `${DSP_Y_ORIGIN}uc-${useCaseName}/js/bidding-logic.js`, |
There was a problem hiding this comment.
Can we change this to uc-ba here too? Since this function is specific to B&A
| app.get('/uc-:useCaseName', async (req: Request, res: Response) => { | ||
| const {useCaseName} = req.params; | ||
|
|
||
| res.render(`uc-${useCaseName}`, { |
Description
This PR sets up the participant skeletons for the B&A mixed-mode multi-seller demo
Component Seller X
Component Seller Y
Buyer X
Buyer Y
Affected services