Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Video Streaming [new?] #1150

Closed
wants to merge 27 commits into from
Closed

Video Streaming [new?] #1150

wants to merge 27 commits into from

Conversation

ggg27
Copy link
Contributor

@ggg27 ggg27 commented Aug 13, 2019

Description: Add Video Streaming Section
After the discussion in #671 many users realized most torrenting based streaming clients hadn't matured enough. I hope this PR takes us in the right direction.

What is added?:

  • MediaGoblin
  • Invidio/Freetube

Worth Mentioning:

Why not LBRY or Peertube?:
lbryio/lbry-sdk#1435 , Chocobozzz/PeerTube#313 , plus PeerTube hasn't (or doesn't even plan) to release a WebRTC free version: https://forum.privacytools.io/t/discussion-fixing-webrtc/1226

Otherwise, I'd say go for it. But, until they fix these they aren't really for that good for "privacy".

But what about ___?: I'm open to suggestions.
Edits from maintainers are welcome!


Check List

Code Repository (if applicable):

@ggg27 ggg27 requested a review from a team August 13, 2019 07:12
@netlify
Copy link

netlify bot commented Aug 13, 2019

Deploy preview for privacytools-io ready!

Built with commit 746ef41

https://deploy-preview-1150--privacytools-io.netlify.com

Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at it quickly and I will need to look deeper later, but please convert the svg into png.

assets/img/tools/mediagoblin.svg Show resolved Hide resolved
Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have multiple concerns, mainly:

  • not using card v2 or however the cards are usually done
  • svg icon
  • missing discussion issues that this resolves

but please do see all of the ten comments.

README.md Outdated Show resolved Hide resolved
_includes/nav.html Outdated Show resolved Hide resolved
_includes/sections/video-streaming.html Outdated Show resolved Hide resolved
image="/assets/img/tools/mediagoblin.svg"
url="https://www.mediagoblin.org/"
footer="OS: Windows, macOS, Linux, FreeBSD, Web."
description="MediaGoblin is a free/libre distributed server software to share many media types."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand from this description what it does, could you think of it a bit more? The website makes it more clear to me:

MediaGoblin is a free software media publishing platform that anyone can run. You can think of it as a decentralized alternative to Flickr, YouTube, SoundCloud, etc. It's also:

Also is there a discussion of it somewhere? I don't remember hearing of it before and I think we strongly prefer discussion issues first.

Copy link
Contributor Author

@ggg27 ggg27 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mikaela I know of many on Video Streaming.
None in particular for MediaGoblin, but I will start one if it is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mikaela Is the new description better?
Should I list an instance or way to find one?
Examples:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's better, but I don't see a reason to include it.

{% include card.html color="primary"
title="Invidio / FreeTube"
image="/assets/img/tools/freetube.png"
url="https://github.com/FreeTubeApp/FreeTube"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird and I think you should use github from cardv2 instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mikaela I do not understand, could you reiterate?

Copy link
Contributor

@Mikaela Mikaela Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrohorse Could you explain cardv2? I think you have been doing the conversions most recently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%}

{% include card.html color="primary"
title="Invidio / FreeTube"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two should be listed separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also unfamiliar with FreeTube, but it looks interesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeTube is basically the unofficial Invidious desktop client.

Copy link

@zedeus zedeus Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "Invidio" be "Invidious"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeTube is basically the unofficial Invidious desktop client.

That may be so, but it's not the official Invidious desktop client and it doesn't carry the same name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "Invidio" be "Invidious"?

Yes, sorry I thought it was Invidio until just a couple weeks ago and forgot to change it.
Thanks!


<h3>Worth Mentioning</h3>
<ul>
<li><a href="https://github.com/misses-robot/KopyKate-Big/blob/master/README.md">KopyKate</a> - A decentralized uncensored video streaming service on ZeroNet.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not including the whole source, is it?

Copy link
Contributor Author

@ggg27 ggg27 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not including the whole source, is it?

I think so:
https://github.com/misses-robot/KopyKate-Big/blob/master/

Edit: As I recall, sidebar also states some 3rd party stuff on the old version:
https://zero.acelewis.com/#kopykate.bit (proxy)
I'm not sure what is still in use.


Also, I've added a warning to KopyKate.
As it is non-free (https://github.com/misses-robot/KopyKate-Big/issues/22) and uncensored.

Copy link
Contributor

@nitrohorse nitrohorse Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like KopyKate's last commit was early last year and doesn't even have any releases so I'm unsure how this is really useful to mention.

But regardless I think we should pause iterating over feedback in the PR until we've opened a new discussion for suggesting a new "Video Streaming" section like our PR checklist metnions 😄 We can also have a community discussion for what software to include.

Copy link
Contributor Author

@ggg27 ggg27 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize there was already a lot of discussion in https://github.com/privacytoolsIO/privacytools.io/pull/671. I'm still thinking it'd be better to shift this discussion to a new Issue; determine if the section is needed plus the recommended software, then work on the PR which would then be straightforward and not have a lot of churn.

Copy link
Contributor

@nitrohorse nitrohorse Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so

I think I'm coming in late to this but it seems like we shouldn't be discussing what software to include in a PR. That should already be determined before starting to write code IMO.

Copy link
Contributor Author

@ggg27 ggg27 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrohorse The issue is there isn't any active discussion in all 3 of those.
The last actual discussion in #671 was in early May when a warning to LBRY was added.


This PR is basically just #671 without PeerTube and LBRY (with MediaGoblin)

Personally, I like using LBRY and Peertube, but neither work with TOR and aren't my #1 choice. There are open issues on both of these:
Chocobozzz/PeerTube#1886 , lbryio/lbry-sdk#1435 , Chocobozzz/PeerTube#2030

If you don't think WebRTC or no I2P is an issue, then by all means #671 is a good PR.


TL:DR: If you think that you can start an active conversation, then I don't see why you shouldn't.
I just don't see this happening in the current discussions. :)

source_code.md Outdated Show resolved Hide resolved
source_code.md Show resolved Hide resolved
@nitrohorse nitrohorse added the WIP active work in progress, do not merge or PR (yet)! label Aug 14, 2019
Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Invidious and FreeTube are still listed as the same software, which they are not.
  • This is still not cardv2 (however I did forget the discussion on it for 15 days) while a response was expected from me.
  • source_code is messed up
  • there is a merge conflict
  • the apps are still missing discussions
    • I am uncomfortable with listing KopyKate, check it's GitHub.
    • I am not talked into accepting MediaGoblin yet either.

{% include card.html color="primary"
title="Invidio / FreeTube"
image="/assets/img/tools/freetube.png"
url="https://github.com/FreeTubeApp/FreeTube"
Copy link
Contributor

@Mikaela Mikaela Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrohorse Could you explain cardv2? I think you have been doing the conversions most recently.

source_code.md Outdated Show resolved Hide resolved
@ggg27
Copy link
Contributor Author

ggg27 commented Sep 12, 2019

Thanks to @Mikaela's and https://github.com/misses-robot/KopyKate-Big/issues/22 I plan remove KopyKate.

@ggg27
Copy link
Contributor Author

ggg27 commented Sep 12, 2019

  • Invidious and FreeTube are still listed as the same software, which they are not.

This seems to be the general consensus. I will add FreeTube to worth mentioning unless you think it should be added to main.

  • This is still not cardv2 (however I did forget the discussion on it for 15 days) while a response was expected from me.

Sorry, but I am still unaware of how to execute this. [1]

  • source_code is messed up

Should be fixed now

  • there is a merge conflict

I am working on trying to fix this. - Should be fixed now


  • the apps are still missing discussions

  • I am not talked into accepting MediaGoblin yet either.

Would you like for me to create a discussion on the forum?

MediaGoblin has a lot of resources on their website, Wikipedia, or unofficial documentation.

Copy link
Contributor

@djoate djoate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Invidious icon is also too low res; get a higher-res version from https://github.com/omarroth/invidious/blob/master/assets/mstile-150x150.png

freetube.png should be removed if we're not using it.

Need to be converted to cardv2 (it's the layout where every card gets it's own row instead of the cards being squished into one row. Here's an example with cloud storage:

https://github.com/privacytoolsIO/privacytools.io/blob/master/pages/software/cloud.html

https://github.com/privacytoolsIO/privacytools.io/blob/master/_includes/sections/selfhosted-cloud.html

<h3>Worth Mentioning</h3>

<ul>
<li><a href="https://freetubeapp.io/">FreeTube</a> - FreeTube is an free software video streaming client utilizing <a href='https://invidio.us/'>Invidious</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is worth mentioning that one of the key features of FreeTube is that it stores user data on the client and not on a server.

Suggested change
<li><a href="https://freetubeapp.io/">FreeTube</a> - FreeTube is an free software video streaming client utilizing <a href='https://invidio.us/'>Invidious</a></li>
<li><a href="https://freetubeapp.io/">FreeTube</a> - FreeTube is an open-source video streaming client utilizing the <a href='https://invidio.us/'>Invidious API</a>, letting you watch YouTube privately on desktop. All of your user data is stored locally and never sent or published to the internet.</li>

image="/assets/img/tools/invidious.png"
url="https://github.com/omarroth/invidious/wiki/Invidious-Instances"
footer="OS: Windows, macOS, Linux, Web."
description="Invidious, an open-source privacy respecting API for YouTube."
Copy link
Contributor

@djoate djoate Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description="Invidious, an open-source privacy respecting API for YouTube."
description="Invidious is an open-source alternative front-end to YouTube. It has no ads and no need for a Google account to save subscriptions. <a href="https://github.com/omarroth/invidious/wiki/Invidious-Instances">List of Instances</a>"

Invidious isn't just an API; it's also a front-end for YouTube as described by the description and the README of the repo: https://github.com/omarroth/invidious.

We should also make the website link to invidio.us and have the alternate instances separate. That is how searx is handled on privacytools.io

@dawidpotocki
Copy link
Contributor

dawidpotocki commented Oct 26, 2019 via email

Copy link
Contributor

@djoate djoate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cardv2 conversions

Comment on lines +5 to +11
{% include card.html color="success"
title="MediaGoblin"
image="/assets/img/tools/mediagoblin.png"
url="https://www.mediagoblin.org/"
footer="OS: Windows, macOS, Linux, FreeBSD, Web."
description="MediaGoblin is a free/libre tool to host media files in a distributed manner."
%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cardv2, replacing it with this can work:

{% include cardv2.html
title="MediaGoblin"
image="/assets/img/tools/mediagoblin.png"
website="https://www.mediagoblin.org/"
description="MediaGoblin is a free/libre tool to host media files in a distributed manner."
%}

Comment on lines +13 to +19
{% include card.html color="primary"
title="Invidious"
image="/assets/img/tools/invidious.png"
url="https://github.com/omarroth/invidious/wiki/Invidious-Instances"
footer="OS: Windows, macOS, Linux, Web."
description="Invidious, an open-source privacy respecting API for YouTube."
%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cardv2, replacing it with this can work (this takes into account my suggestion from https://github.com/privacytoolsIO/privacytools.io/pull/1150/files#r339316663)

{% include cardv2.html
title="Invidious"
image="/assets/img/tools/invidious.png"
website="https://invidio.us/
description="Invidious is an open-source alternative front-end to YouTube. It has no ads and no need for a Google account to save subscriptions. <a href='https://github.com/omarroth/invidious/wiki/Invidious-Instances'>List of Instances</a>"
github="https://github.com/omarroth/invidious"
%}

@@ -32,6 +32,7 @@
<a class="dropdown-item" href="/providers/search-engines/"><span class="fas fa-search fa-fw"></span> Search Engines</a>
<a class="dropdown-item" href="/providers/social-networks/"><span class="fas fa-expand-arrows-alt fa-fw"></span> Social Networks</a>
<a class="dropdown-item" href="/providers/social-news-aggregator/"><span class="far fa-newspaper fa-fw"></span> Social News Aggregators</a>
<a class="dropdown-item" href="/software/video-streaming/"><i class="fas fa-expand-arrows-alt fa-fw"></i> Video Streaming</a> <a class="dropdown-item" href="/providers/vpn/"><span class="far fa-eye-slash fa-fw"></span> VPN</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've duplicated VPN in the navbar:

Suggested change
<a class="dropdown-item" href="/software/video-streaming/"><i class="fas fa-expand-arrows-alt fa-fw"></i> Video Streaming</a> <a class="dropdown-item" href="/providers/vpn/"><span class="far fa-eye-slash fa-fw"></span> VPN</a>
<a class="dropdown-item" href="/software/video-streaming/"><i class="fas fa-expand-arrows-alt fa-fw"></i> Video Streaming</a>

@ghost
Copy link

ghost commented Feb 13, 2020

plus PeerTube hasn't (or doesn't even plan) to release a WebRTC free version

The p2p player can be disabled in PeerTube and thus removing any privacy concerns of user's IPs being visible to other peers who are watching a certain video. Currently there are only 2 ways to disable it:

  • if the server admin has disabled it for the entire instance
  • disable it in your account settings

The feature that would allow non-registered users to disable the p2p player hasn't yet been developed Chocobozzz/PeerTube#2271

@ian-tedesco
Copy link

plus PeerTube hasn't (or doesn't even plan) to release a WebRTC free version

The p2p player can be disabled in PeerTube and thus removing any privacy concerns of user's IPs being visible to other peers who are watching a certain video. Currently there are only 2 ways to disable it:

* if the server admin has disabled it for the entire instance

* disable it your account settings

The feature that would allow non-registered users to disable the p2p player hasn't yet been developed Chocobozzz/PeerTube#2271

Still I think this is a half cooked solution, without P2P there isn't much to a decentralized platform.

@ghost
Copy link

ghost commented Feb 13, 2020

Still I think this is a half cooked solution, without P2P there isn't much to a decentralized platform.

That's not true. ActivityPub makes PeerTube decentralized. The p2p player is there to reduce server load and save bandwidth.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ℹ️ help wanted WIP active work in progress, do not merge or PR (yet)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants