-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Hopefully) some improvements to Kotlin code and some general cleanup #7
Commits on Apr 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7292b0c - Browse repository at this point
Copy the full SHA 7292b0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48e177d - Browse repository at this point
Copy the full SHA 48e177dView commit details -
Removed JvmStatic annotations in FahConstants object, as I think they…
… are not needed. As far as I can see, this object is intended for internal use only, so it would only be used in Kotlin, and most of the fields can be declared as const values instead.
Configuration menu - View commit details
-
Copy full SHA for 2ba2af4 - Browse repository at this point
Copy the full SHA 2ba2af4View commit details -
Some refactoring in FahManager:
- Removed explicit android.support.annotation.NonNull annotation, as non-nullable Kotlin variables and parameters are annotated with org.jetbrains.annotations.NotNull, which should serve the same purpose. - Moved constants into private companion object, so they would become actual static constants. - Moved some stuff out of init{} block directly into property declarations. This removes the need for some fields being nullable, where they don't need to be and still behaves as if being set in the init{} block. - Removed hungarian notation for private properties. Left it in for mTimeOutLeft and mTriesCountLeft for now, as they could potentially be intended to be part of the exposed API. - Removed the need for the !! operator.
Configuration menu - View commit details
-
Copy full SHA for 78c0134 - Browse repository at this point
Copy the full SHA 78c0134View commit details -
Some refactoring in FahSecureSettingsDialog:
- Fixed spelling error with setPositive and deprecated setPostisive methods. - Moved some stuff out of the Builder's init{} block directly into property declarations. - Removed hungarian notation for private properties. - Removed the need for the !! operator by making the context property not-nullable, lazily initializing the dialog, and not handling fallbacks for string properties directly in show() but directly where they are initialized.
Configuration menu - View commit details
-
Copy full SHA for 6d5c77b - Browse repository at this point
Copy the full SHA 6d5c77bView commit details -
Some minor refactoring in FahTimeOutService
- Removed hungarian notation. - Removed the need for the !! operator by using the elvis operator. - Made broadcastIntent property not-nullable by lazily initializing.
Configuration menu - View commit details
-
Copy full SHA for 46d7b4d - Browse repository at this point
Copy the full SHA 46d7b4dView commit details -
Some refactoring of FingerprintAuthHelper (with backwards compatibili…
…ty for Java and Kotlin) - Removed hungarian notation. - Changed most private properties with extra getter functions into public ones with custom getters. - Changed isSdkVersionOk from function to lazily initialized property. - Changed FahManager reference to be immutable and initialize it immediately with either a correct reference or null. This removed the need for the !! operator or even ?. with proper null checks and implicit casts. - Added JvmName annotations to properties, where the implicit getter name didn't match the removed getter function. - Deprecated explicit getter functions, which should not be used anymore and set bogus JvmName annotations to avoid naming clashes with Java names.
Configuration menu - View commit details
-
Copy full SHA for d52e111 - Browse repository at this point
Copy the full SHA d52e111View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1039969 - Browse repository at this point
Copy the full SHA 1039969View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b5c2be - Browse repository at this point
Copy the full SHA 7b5c2beView commit details -
Small tweak to FingerprintAuthHelper deprecation handling. Instead of…
… still using the old cleanTimeOut method, that method is now fully deprecated and implicit isTimeOutCleaned() method should be used instead.
Configuration menu - View commit details
-
Copy full SHA for 1c50524 - Browse repository at this point
Copy the full SHA 1c50524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 664f99e - Browse repository at this point
Copy the full SHA 664f99eView commit details -
Messed up some properties in commit d52e111 by using the property in …
…the getter instead of field.
Configuration menu - View commit details
-
Copy full SHA for 965702c - Browse repository at this point
Copy the full SHA 965702cView commit details -
Changed cleanTimeOut() back to regular function, but without backing …
…property this time, as that one wasn't needed.
Configuration menu - View commit details
-
Copy full SHA for d3952dc - Browse repository at this point
Copy the full SHA d3952dcView commit details
Commits on Apr 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for db80296 - Browse repository at this point
Copy the full SHA db80296View commit details
Commits on Apr 18, 2017
-
Fixed another typo in FahErrorType.Auth.AUTH_TOO_MANY_RETRIES and dep…
…recated FahErrorType.Auth.AUTH_TO_MANY_RETRIES.
Configuration menu - View commit details
-
Copy full SHA for 23ba555 - Browse repository at this point
Copy the full SHA 23ba555View commit details