Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Error in catalog directory creation #1044

Merged
merged 16 commits into from
Jul 24, 2024
Merged

Conversation

eshanjain1
Copy link
Collaborator

There is a small typo in the catalog directory creation.

@eshanjain1 eshanjain1 requested a review from jeff-regier July 18, 2024 19:51
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but please resolve the merge conflicts

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (2cefde4) to head (d089295).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files          23       23           
  Lines        2874     2874           
=======================================
  Hits         2328     2328           
  Misses        546      546           
Flag Coverage Δ
unittests 81.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeff-regier jeff-regier merged commit 1db2ad4 into master Jul 24, 2024
3 checks passed
@jeff-regier jeff-regier deleted the ej/strong_lensing branch July 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants