Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak lensing: data aug + recent DC2 results with baselines #1077

Merged
merged 22 commits into from
Oct 19, 2024

Conversation

timwhite0
Copy link
Collaborator

Recent results on DC2:

BLISS:
test loss: -10.49
shear 1 test MSE: 5.3e-05
shear 2 test MSE: 5.4e-05
convergence test MSE: 6.1e-05

Baseline estimator based on true ellipticities:
shear 1 test MSE: 4.9e-05 
shear 2 test MSE: 5.1e-05

Predicting zero in every tile:
shear 1 test MSE: 6.7e-05
shear 2 test MSE: 6.4e-05

See notebooks/dc2/evaluate_encoder.ipynb in our case study for corresponding shear/convergence maps and scatterplots. Our previous results (#1074) should be disregarded because they were affected by #1075 and #1076.

Updates in this PR:

  • Implemented two data augmentation transforms: flips and 90 degree rotations. The effects of these transforms on shear are documented in notebooks/weak_lensing_sims/data_augmentation.ipynb.
  • Added the average ellipticity baseline estimator to lensing_metrics.
  • Added ra/dec to the tile catalog.

@timwhite0 timwhite0 requested a review from jeff-regier October 19, 2024 15:44
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (4694457) to head (720973c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files          22       22           
  Lines        3092     3092           
=======================================
  Hits         2355     2355           
  Misses        737      737           
Flag Coverage Δ
unittests 76.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-regier jeff-regier merged commit 0eb412b into master Oct 19, 2024
3 checks passed
@jeff-regier jeff-regier deleted the tw/weak_lensing branch October 19, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants