fix: Fix quickstart instruction in CLI

[thomass-dev]

Closes #995 .

[github-actions]

pytest coverage report

File	Stmts	Miss	Cover	Missing
src/skore
__init__.py	12	0	100%
__main__.py	8	1	1	80%
exceptions.py	4	0	100%
src/skore/cli
__init__.py	5	0	100%
cli.py	35	0	100%
launch_dashboard.py	26	15	0	39%
quickstart_command.py	15	2	0	87%
src/skore/item
__init__.py	21	0	100%
cross_validation_item.py	127	10	2	92%
item.py	41	13	0	68%
item_repository.py	42	2	1	93%
media_item.py	70	4	1	94%
numpy_array_item.py	25	1	1	93%
pandas_dataframe_item.py	34	1	1	95%
pandas_series_item.py	34	1	1	95%
polars_dataframe_item.py	32	1	1	94%
polars_series_item.py	27	1	1	94%
primitive_item.py	27	2	1	92%
sklearn_base_estimator_item.py	33	1	1	95%
skrub_table_report_item.py	10	1	1	86%
src/skore/persistence
__init__.py	0	0	100%
abstract_storage.py	22	1	0	95%
disk_cache_storage.py	33	1	1	95%
in_memory_storage.py	20	0	100%
src/skore/project
__init__.py	4	0	100%
create.py	54	8	0	88%
load.py	23	3	0	89%
project.py	64	4	4	91%
src/skore/sklearn
__init__.py	3	0	100%
find_ml_task.py	35	3	2	89%
types.py	2	0	100%
src/skore/sklearn/cross_validation
__init__.py	2	0	100%
cross_validation_helpers.py	41	4	1	89%
cross_validation_reporter.py	37	1	1	95%
src/skore/sklearn/cross_validation/plots
__init__.py	0	0	100%
compare_scores_plot.py	29	1	2	92%
timing_normalized_plot.py	29	1	1	94%
timing_plot.py	29	1	1	94%
src/skore/sklearn/train_test_split
__init__.py	0	0	100%
train_test_split.py	34	2	1	94%
src/skore/sklearn/train_test_split/warning
__init__.py	8	0	100%
high_class_imbalance_too_few_examples_warning.py	17	3	2	78%
high_class_imbalance_warning.py	18	2	1	88%
random_state_unset_warning.py	11	1	1	87%
shuffle_true_warning.py	9	0	1	91%
stratify_is_set_warning.py	11	1	1	87%
time_based_column_warning.py	22	1	2	89%
train_test_split_warning.py	5	1	0	80%
src/skore/ui
__init__.py	0	0	100%
app.py	25	5	2	71%
dependencies.py	7	1	0	86%
project_routes.py	50	0	100%
src/skore/utils
__init__.py	0	0	100%
_logger.py	21	4	0	84%
_show_versions.py	29	0	100%
src/skore/view
__init__.py	0	0	100%
view.py	5	0	100%
view_repository.py	16	2	1	83%
TOTAL	1343	107	91%

Tests	Skipped	Failures	Errors	Time
210	0 💤	0 ❌	0 🔥	48.183s ⏱️

[MarieS-WiMLDS]

I tried the fix and it works for me, thanks!
However I still don't understand why the test was crashing, did you understand? I have some doubts that it's doing its job since it didn't catch the error before.

[augustebaum]

I tried the fix and it works for me, thanks! However I still don't understand why the test was crashing, did you understand? I have some doubts that it's doing its job since it didn't catch the error before.

I'm guessing it's because the test is very basic and doesn't actually run the real launch command.

[augustebaum]

Nice, thanks!

[thomass-dev]

@MarieS-WiMLDS the test was wrong and has replicated the same behavior of the bug, this is why it was green.

It tested that the directory was well passed to the create function, but not to the launch function.
If we had tested assert launch_project_name == "hello/my_project.skore", we would have discovered the bug.
Thanks for the feedback, well spotted.