Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix CONTRIBUTING.md to create project #1049

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Jan 6, 2025

Closes #1026 .

Copy link
Contributor

@sylvaincom sylvaincom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did not review the code but tried it out and it works. But in the quick start, do we actually want someone to do all of that?

make install-skore
skore create
make build-skore-ui
make serve-skore-ui

@augustebaum
Copy link
Contributor

Thanks, I did not review the code but tried it out and it works. But in the quick start, do we actually want someone to do all of that?

make install-skore
skore create
make build-skore-ui
make serve-skore-ui

All of these steps do meaningful things; for now this seems like the simplest workflow

@augustebaum augustebaum merged commit 8d032ab into main Jan 6, 2025
8 checks passed
@augustebaum augustebaum deleted the fix-contributing-guide branch January 6, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: In the contributing guide, make serve-skore-ui does not work.
3 participants