Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add example to showcase EstimatorReport and CrossValidationReport #1156

Merged
merged 133 commits into from
Jan 22, 2025
Merged

docs: Add example to showcase EstimatorReport and CrossValidationReport #1156

merged 133 commits into from
Jan 22, 2025
+556 −1

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jan 19, 2025 •
edited
Loading

Build upon #1091
We should merge #1091 to make it easy to review.

This PR revisits the documentation for the EstimatorReport and CrossValidationReport.

The idea is to provide different examples for different purposes:

  • technical section: it is a section to explain more in details some internal for user that might be interested. I think that we should move those inside this specific section because we should have more a pure data science section to only show the added values of our tools on data science
  • use-case section: it is indeed the section to show case our tools on real data. Here we want to show the added value on the data science side.

@glemaitre
feat: Revamp CrossValidationReport to use EstimatorReport
76d72c6
@glemaitre
Merge remote-tracking branch 'origin/main' into cross_validation_repo…
98d94d7 
…rt_3
@glemaitre
add progress bar
8353b00
@glemaitre
iter
b695666
@glemaitre
make sure to use shared memory
4f8aa1c
@glemaitre
fix progress bar glitches
5a42157
@glemaitre
fix attribute sorting
e4accc8
@glemaitre
iter
5ace5be
@glemaitre
add metric accessor class
c6333ca
@glemaitre
iter
82f64cb
@glemaitre
add custom metric
b47786e
@glemaitre
iter
fe110ff
@glemaitre
roc curve
35e01ea
@glemaitre
iter
4d0f16f
@glemaitre
iter
d46199e
@glemaitre
some cache optimization
ae11e23
@glemaitre
hash computation optimization
e3a8a59
@glemaitre
provide a way to send pos_label
68755aa
@glemaitre
iter
3175047
@glemaitre
iter
0256166
@glemaitre
iter
8e6a532
@glemaitre
more parallelism
2635f56
@glemaitre
bug
23fd1aa
@glemaitre
Merge remote-tracking branch 'origin/main' into cross_validation_4
3ae4da8
@glemaitre
convert class decorator to function decorator
7dfe4a4
@glemaitre
simplify progress bar
31a9ba3
@glemaitre
feat: Allow for nested progress bar
071daa5
@glemaitre
actually add the file to git
8414c20
@glemaitre
more comment
5238fdc
@glemaitre
chore: More readable version of iterating
3a97df2
@glemaitre glemaitre marked this pull request as ready for review January 22, 2025 14:49
@sylvaincom
Copy link
Contributor

Please address this 🙏

#1156 (review)

@glemaitre
Copy link
Member Author

@sylvaincom already done ;)

@glemaitre
Copy link
Member Author

I prefer the use-case to be higher. It should the one thing our user should look at.

MarieS-WiMLDS
MarieS-WiMLDS previously approved these changes Jan 22, 2025
View reviewed changes
@MarieS-WiMLDS MarieS-WiMLDS merged commit 501ad11 into probabl-ai:main Jan 22, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvaincom sylvaincom sylvaincom left review comments

@MarieS-WiMLDS MarieS-WiMLDS MarieS-WiMLDS approved these changes

@thomass-dev thomass-dev Awaiting requested review from thomass-dev thomass-dev is a code owner

@rouk1 rouk1 Awaiting requested review from rouk1 rouk1 is a code owner

@auguste-probabl auguste-probabl Awaiting requested review from auguste-probabl auguste-probabl is a code owner

Assignees

@glemaitre glemaitre

Labels
None yet
Projects
None yet
Milestone
Skore 0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@glemaitre @augustebaum @sylvaincom @MarieS-WiMLDS @rouk1