Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Hide mentions of the skore UI #1184

Merged
merged 2 commits into from
Jan 21, 2025
Merged

docs: Hide mentions of the skore UI #1184

merged 2 commits into from
Jan 21, 2025

Conversation

sylvaincom
Copy link
Contributor

Fix #1170

@sylvaincom sylvaincom linked an issue Jan 21, 2025 that may be closed by this pull request
docs: Hide mentions of the skore UI #1170
Closed
@sylvaincom sylvaincom marked this pull request as ready for review January 21, 2025 10:43
@sylvaincom sylvaincom added this to the Skore 0.6 milestone Jan 21, 2025
auguste-probabl
auguste-probabl approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@auguste-probabl auguste-probabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, thanks!

@auguste-probabl auguste-probabl merged commit fb744f2 into main Jan 21, 2025
3 of 7 checks passed
@auguste-probabl auguste-probabl deleted the 1170-docs-hide-mentions-of-the-skore-ui branch January 21, 2025 11:20
thomass-dev
thomass-dev requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@thomass-dev thomass-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove images/gif that are not used anymore, in any documentation version.
Note that i can delete the documentation 0.5, as we don't have active users.

@thomass-dev
Copy link
Collaborator

@sylvaincom please take in account my comment in another PR :)

@sylvaincom sylvaincom mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomass-dev thomass-dev thomass-dev requested changes

@auguste-probabl auguste-probabl auguste-probabl approved these changes

Assignees

@sylvaincom sylvaincom

Labels
None yet
Projects
None yet
Milestone
Skore 0.6
Development

Successfully merging this pull request may close these issues.

docs: Hide mentions of the skore UI
3 participants
@sylvaincom @thomass-dev @auguste-probabl