chore(UI): Remove view builder #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
remove skore/src/skore/persistence/repository/view_repository.py
Coverage Report for backend
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
MarieS-WiMLDS
requested changes
Jan 31, 2025
There was a problem hiding this comment.
I tried with the window covering half of my screen, and it's great!! I really like that there is little margin, in a context where I need all the space to be useful. I also like where the annotation pencil is now.
I noticed these three points, none of them is a big deal.
point 1
when hovering the project name, it gives me the location. It's nice so i'm not lost, but i'd like to have it complete. Is it possible to display it on several lines? or on the right?
point 2
I don't think that it's something introduced in the PR, but if it's not too difficult, when the item contains text, I'd like to have it in a grey rectangle like the other objects, otherwise it get mixed with the notes (cf below).
point 3
I like the idea to have a #n after the object name to display that there is another one! But it's very small, i had a hard time reading.
…at the bottom start of the related element.
…u can find pretty much everywhere
s Please enter the commit message for your changes. Lines starting
Point 1Tooltip will now never be larger than 50% of the viewport and placed at the bottom start of the related element.
Point 2Nice catch !
Point 3Ok it's now the same size as the name of the item. |
|
it's good for me from a functional point of view, thanks :) ! |
auguste-probabl
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1266.
This PR removes all view builder related code.
Activity feed item now have a version number in backend aswell as in frontend.
User can now annotate there items in the activity feed.
UI preview:
feed.mp4