-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : After selecting year/month datepicker getting closed in IOS #85
fix : After selecting year/month datepicker getting closed in IOS #85
Conversation
@probablykasper please have a look at this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This messes with the focus behavior:
Screen.Recording.2024-02-26.at.16.02.15.mov
@probablykasper fixed please check now |
The issue is that the |
got your point let me work on it |
6590996
to
1bc7d31
Compare
imo it should be looked into if there's a decent way to keep the |
@probablykasper so i did bit of research like what can be the done to keep select focus but it seems there is no proper way to do it other than using setTimeout. there are ways to get relatedTarget but we will have to give tabIndex = "0" to wrapper divs of select tags can we handle this case specific to iphone and ipad so that existing a11y remain unaffected? because anyways a11y seems broken in the case of iphone and ipad as datepicker itself is closing after selecting month/year |
Yes it can be iOS-specific |
In IOS select tag looses focus, since its default behaviour of IOS safari to focus out from select tag once the option is selected.
so here we focus on wrapper div of select tag, this makes wrapper div as the related target in the onFocusOut event, and visible still remains true