fix(fbref):Handle yellow card events for non-players (#566)

Fixes #544 Co-authored-by: Pieter Robberechts <[email protected]>
probberechts · May 9, 2024 · dbeaea3 · dbeaea3
1 parent 55d80ca
commit dbeaea3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/soccerdata/fbref.py b/soccerdata/fbref.py
@@ -984,7 +984,7 @@ def read_events(
                 for e in html_events:
                     minute = e.xpath("./div[1]")[0].text.replace("&rsquor;", "").strip()
                     score = e.xpath("./div[1]/small/span")[0].text
-                    player1 = e.xpath("./div[2]/div[2]/div/a")[0].text
+                    player1 = e.xpath("./div[2]/div[2]/div")[0].text_content().strip()
                     if e.xpath("./div[2]/div[2]/small/a"):
                         player2 = e.xpath("./div[2]/div[2]/small/a")[0].text
                     else:

diff --git a/tests/test_FBref.py b/tests/test_FBref.py
@@ -91,6 +91,14 @@ def test_read_events(fbref_ligue1: FBref) -> None:
     assert isinstance(fbref_ligue1.read_events(match_id="796787da"), pd.DataFrame)
 
 
+def test_read_events_yellow_for_manager() -> None:
+    """When a yellow card given to the manager, there is no <a> tag."""
+    fbref_laliga = sd.FBref("ESP-La Liga", "23-24")
+    events = fbref_laliga.read_events(match_id="e8867e6b")
+    yellow_cards = events[events["event_type"] == "yellow_card"]
+    assert "Pepe Bordalás" in yellow_cards["player1"].tolist()
+
+
 def test_read_shot_events(fbref_ligue1: FBref) -> None:
     assert isinstance(fbref_ligue1.read_shot_events(match_id="796787da"), pd.DataFrame)