Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to extract players URL in FBREF #806

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaelromagne
Copy link

This PR adds an option in the read_player_season_stats method. When extracting player statistics, it may be interesting to get the URL to the player page as well. This way, we can get additional information in our application with a simple scraping on the player page (for instance, the player picture).

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.75%. Comparing base (69fb0de) to head (43615c7).
Report is 248 commits behind head on master.

Files with missing lines Patch % Lines
soccerdata/fbref.py 65.21% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #806       +/-   ##
===========================================
+ Coverage   59.33%   73.75%   +14.41%     
===========================================
  Files          11       26       +15     
  Lines        1633     2496      +863     
  Branches      336      341        +5     
===========================================
+ Hits          969     1841      +872     
+ Misses        610      575       -35     
- Partials       54       80       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant