Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add protocols column to requests_dnf #8

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

kasteph
Copy link
Contributor

@kasteph kasteph commented Oct 17, 2024

No description provided.

@guillaumemichel
Copy link
Contributor

I just ran the ants, and it seems that the protocols aren't added to the denormalized requests table (column is there but empty).

Also wrt normalization there are two tables protocols and protocols_sets like for nebula, which seems good. I guess the code to normalize protocols can also be imported from nebula?

@kasteph
Copy link
Contributor Author

kasteph commented Oct 17, 2024

I just ran the ants, and it seems that the protocols aren't added to the denormalized requests table (column is there but empty).

Yep, I thought it was supposed to be kept empty for now, so I haven't added it at the moment.

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that we don't need it now. Let's add it later when we need it

@kasteph kasteph merged commit f64f4f1 into main Oct 21, 2024
2 checks passed
@kasteph kasteph deleted the feat/protocols-col branch October 21, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants