Add chipDescriptionPath #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noppej
previously requested changes
Jan 15, 2024
There was a problem hiding this comment.
As you've hinted at, I'm using this "request changes" to block this merge until we have merged and released probe-rs/probe-rs#2050 :)
|
This needs resolving :) |
|
First probe-rs needs a new release :P I'll wait for resolving this in case we end up breaking it again |
@noah ... I'm not sure I fully understand what you mean by "needs resolving". Do you have a request beyond the comment I made at #71 (review) ? |
|
@noppej sorry I only see the comment now: I meant the merge conflicts :) |
Yatekii
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing this needs probe-rs/probe-rs#2050 and it's also untested