Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to dap_server changes to send errors via DAP vs stderr. #94

Merged
merged 4 commits into from
May 21, 2024
Merged

Adjust to dap_server changes to send errors via DAP vs stderr. #94

merged 4 commits into from
May 21, 2024
+66 −81

Conversation

noppej
Copy link
Contributor

@noppej noppej commented May 20, 2024

@noppej noppej requested a review from bugadani May 20, 2024 20:53
@noppej noppej mentioned this pull request May 20, 2024
Merged
bugadani
bugadani reviewed May 21, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
@noppej noppej requested a review from bugadani May 21, 2024 13:13
bugadani
bugadani approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@bugadani bugadani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Not sure if you want to wait for the companion PR so I refrain from pushing the Big Green Button for now.

@noppej noppej merged commit 5e3f8e4 into master May 21, 2024
3 checks passed
@noppej noppej deleted the debug_server_tracing branch May 21, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugadani bugadani bugadani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noppej @bugadani