docs: fix outdated cli call #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiwalun
reviewed
Oct 29, 2023
content/docs/tools/cargo-flash.md
Outdated
| @@ -36,7 +36,7 @@ cargo flash --release --chip <chip_name> | |||
|
|
|||
| # Don't know if your target is supported | |||
| # by cargo flash and what it's name is? | |||
| cargo flash --list-chips | |||
| probe-rs info | |||
There was a problem hiding this comment.
I think probe-rs chip list would be a better match, probe-rs info will just show some information about the debug interface of a connected chip, but you can't figure out the target name with it.
There was a problem hiding this comment.
sounds good to me, changed, pushed!
daringer
force-pushed
the
fix-list-chips
branch
from
0b0d752
to
66c6924
Compare
Tiwalun
requested changes
Oct 30, 2023
content/docs/tools/cargo-flash.md
Outdated
| @@ -36,7 +36,7 @@ cargo flash --release --chip <chip_name> | |||
|
|
|||
| # Don't know if your target is supported | |||
| # by cargo flash and what it's name is? | |||
| cargo flash --list-chips | |||
| probe-rs chip info | |||
There was a problem hiding this comment.
probe-rs chip info still requires a name, probe-rs chip list will list all known chips.
There was a problem hiding this comment.
naaah, sry :D next try incoming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs are outdated here, there is no more
--list-chips- the equivalent seems to beprobe-rs info.This fixes: probe-rs/probe-rs#1736