Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print performance number #531

Closed
wants to merge 4 commits into from
Closed

Print performance number #531

wants to merge 4 commits into from

Conversation

probonopd
Copy link
Owner

@probonopd probonopd commented Aug 11, 2023

In the Performance menu, print the number of the performance.

#414 (comment)

@probonopd
Copy link
Owner Author

probonopd commented Aug 11, 2023

MiniDexed_2023-08-11-15bc1a8

Not quite right yet; at the moment it shows the number of the currently loaded performance rather than the number of the performance being looked at.

@Banana71
Copy link

That was very fast :-)

The numbering is not displayed when the performance is selected, only when it is loaded.
The numbering is wrong, the number from the file name is not displayed but a consecutive number.

@Banana71
Copy link

MiniDexed_2023-08-11-8a2c8e2 shows the whole file name including the file extension

@probonopd
Copy link
Owner Author

probonopd commented Aug 12, 2023

This is now somewhat consistent with the voice selection screen. It's the best I can do at the moment. Please test: MiniDexed_2023-08-12-9ebbff6

@Banana71
Copy link

Thank you @probonopd ,

The numbering is correctly taken from the file name.
The performance number is displayed on the second line before the performance name.
The file name is shortened by the corresponding digits of the numbering.

miniDexed Display s

@probonopd
Copy link
Owner Author

probonopd commented Aug 12, 2023

Looks like we have 3 more characters available on the OLED than on the 16x2 display. We should probably make use of them. :)

@Banana71
Copy link

Looks like we have 3 more characters available on the OLED than on the 16x2 display. We should probably make use of them. :)

20 - 16 = 3 😂🤷‍♂️🥰🖖🏼

@probonopd
Copy link
Owner Author

probonopd commented Aug 12, 2023

Don't forget the < and >
So I was assuming 16-2 = 14. But on the OLED we have 4 more (depending on the font used).

@probonopd
Copy link
Owner Author

@diyelectromusic do we have "if OLED then use more characters" like logic in other places already?

@diyelectromusic
Copy link
Contributor

@diyelectromusic do we have "if OLED then use more characters" like logic in other places already?

There is a configuration option to extend the width for oled displays: https://github.com/probonopd/MiniDexed/wiki/Files#ssd1306-oled

But it isn't ideal. I seem to recall there is at least one place where there were hard-coded 16-characters, but can't remember exactly where.... might be something like the volume control.

Kevin

@probonopd
Copy link
Owner Author

Closing in favor of #581, thanks @diyelectromusic

@probonopd probonopd closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants