Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make performance directory switchable #575

Closed
wants to merge 4 commits into from
Closed

Conversation

probonopd
Copy link
Owner

@probonopd probonopd commented Dec 2, 2023

With so many performances to choose from, we need a way to switch between multiple directories (folders) of performances.

Intended behavior:

  • We can have performance/000000_factory/, performance/000001_somefolder/, performance/000002_someotherfolder/instead of a hardcodedperformance/` directory
  • By sending the MIDI Bank Change messages on the MIDI channel configured for selecting performances (rather than voices), the directory can be switched
  • It can also be switched in the UI

TODO:

  • The changes in performanceconfig.* need to be reviewed; in CPerformanceConfig::SetPerformanceDir the performances from the new performance directory need to be loaded
  • The changes in src/mididevice.cpp are pseudo-code and need to be implemented properly
  • The Performances menu entry should get a new submenu to change the performance directory without using MIDI bank change messages

This PR is currently not functional because the TODOs need to be implemented. Any help appreciated. Volunteers?

Depending on whether we get a MSB or LSB, we need to change the performance directory or do a program change
@probonopd probonopd marked this pull request as draft December 2, 2023 20:08
@probonopd
Copy link
Owner Author

Closing in favor of @diyelectromusic's solution that has been merged.

@probonopd probonopd closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant