Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved(?) upload.sh script, solving issues related to release notifications? #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aferrero2707
Copy link
Contributor

No description provided.

@probonopd
Copy link
Owner

Thank you very much @aferrero2707. Once we have 3 users to confirm that this works for them, I'll go ahead and merge this.

@TheAssassin
Copy link
Contributor

Dug out this feature proposal, which has been open for a while. @probonopd please re-review, I don't think anyone will confirm anything here. I'd say, merge it, and if there should be problems, people can open new issues.

@probonopd
Copy link
Owner

@TheAssassin can you confirm that it works for you?

@TheAssassin
Copy link
Contributor

Never tried, and don't think I will get to that soon.

@probonopd
Copy link
Owner

@aferrero2707 can you please add a description to the PR? What does it do? Thanks.

@probonopd
Copy link
Owner

@aferrero2707 I am sure you are doing great work here, but could you please describe which issues this patch tries to resolve or which features it adds? Thanks.

@aferrero2707
Copy link
Contributor Author

The updated scripts in this PR add the following features:

  • the release tag is passed as first parameter, thus allowing to use tags different from "continuous" (for example "nightly")
  • the upload.sh tool only removes the release and corresponding tag if they actually exist
  • a new upload_rotate.sh script is added, which does not delete/recreate the release and tag, but instead they add assets to the existing release (it still gets created if it does not exist)
  • a new remove.sh script is added, which allows to remove from a given release the existing assets matching the given prefix & suffix patterns

@probonopd
Copy link
Owner

Thanks @aferrero2707. Are you already using the improved version somewhere?

@aferrero2707
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants