Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move to ESM #98

Merged
merged 7 commits into from
Mar 18, 2024
Merged

feat: Move to ESM #98

merged 7 commits into from
Mar 18, 2024

Conversation

AaronDewes
Copy link
Member

@AaronDewes AaronDewes commented Mar 9, 2024

BREAKING CHANGE: Use ESM
BREAKING CHANGE: Use Probot v13

gr2m
gr2m previously approved these changes Mar 12, 2024
@gr2m
Copy link
Contributor

gr2m commented Mar 12, 2024

sorry just saw it's still WIP 😅

@gr2m gr2m dismissed their stale review March 12, 2024 17:08

still WIP

@AaronDewes
Copy link
Member Author

It just needs an update to the latest adapter release, which I'll do soon

@AaronDewes AaronDewes changed the title WIP: Move to ESM feat: Move to ESM Mar 13, 2024
Use Node 20 because that's what the action will use when being run
@AaronDewes
Copy link
Member Author

AaronDewes commented Mar 13, 2024

I'll check why this fails now...

The test doesn't even use the adapter, so it is probably related to Probot...

@AaronDewes AaronDewes merged commit d074d5e into main Mar 18, 2024
3 checks passed
@AaronDewes AaronDewes deleted the esm branch March 18, 2024 12:32
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants