-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete content-length header so it is recalculated for request. #122
Conversation
Can I know when it is going to merge so that we can use this for Bitbucket |
Any news about the merge? I would want to use bitbucket webhook. |
This one also resolves #136. superagent po @JasonEtco @tcbyrd would you mind please take a look at this? |
The fix proposed in probot#122
Any chance this can get merged? |
This fixed our issue. Thanks! |
@JasonEtco @hiimbex @rpetti @tcbyrd any objections to merging this one? |
I'm not totally familiar with this project, but the change seems reasonable to me. |
Is this going to get merged? I could really use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work for Jenkins. The content-length header must be set.
@Frechetta the content-length header gets recreated when you send the request to Jenkins. The problem is if you leave the existing one it is left to the existing value which is incorrect. I ran this with Jenkins for many months |
For some reason, for the endpoints for the bitbucket plugin and the bitbucket branch source plugin, deleting the content-length header didn't work for me. What did work was explicitly setting the content-length header to the new length of the data body.
Thanks,
Eric
…On Apr 21, 2020, 11:15 PM, at 11:15 PM, JamesMc86 ***@***.***> wrote:
@Frechetta the content-length header gets recreated when you send the
request to Jenkins.
The problem is if you leave the existing one it is left to the existing
value which is incorrect.
I ran this with Jenkins for many months
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#122 (comment)
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
The fix proposed in probot#122
This fixes #116.
Content-length should be recalculated but the code was overwriting it with the original length which has changed (for some unknown reason).