fixes commander 9.0.0 opts and http content-length violation #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commander fix is necessary to run the current master branch, which is currently broken. It would be great if this could be merged and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP header and we should not override it, since we usesuperagentas HTTP client, it should set its downcontent-length` header and we should not override it. This fixes scenarios where the payload encoded by superagent does not match the content-length received by the smee service. Fixes Smee seems to reformat JSON without updating Content-Length header #136 and Error forwarding Bitbucket Cloud to Internal Jenkins #116smee.js, commander 9.0.0 (fix(deps): update dependency commander to v9 #211) usesprogram.opts()to expose parsed commands