documentation of amplitude.disconnect() method #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
davepagurek
reviewed
Nov 23, 2022
| * | ||
| * function draw() { | ||
| * background(220); | ||
| * text('Disconnect:', 20, 20); |
There was a problem hiding this comment.
Maybe we can make the text "Click to disconnect" so it's clearer you can click anywhere?
davepagurek
reviewed
Nov 23, 2022
| * function togglePlay() { | ||
| * if (sound.isPlaying()){ | ||
| * sound.pause(); | ||
| * amplitude.disconnect(); |
There was a problem hiding this comment.
I think calling disconnect here might not be the best illustration of what's going on since disconnect only disconnects the amplitude's outputs. If we don't call sound.pause() on the line above, nothing appears to happen. Is there an example we can make where we connect the amplitude's output to something else, so that we can disconnect the amplitude's output from that rather than pausing its input?
There was a problem hiding this comment.
Should we make a separate button for the disconnect method?
|
@davepagurek please check PR #686. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation of amplitude.disconnect() method with example.