-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) : Added Headless Testing #733
base: main
Are you sure you want to change the base?
(chore) : Added Headless Testing #733
Conversation
Signed-off-by: Abhijay Jain <[email protected]>
… Abhijay007/Headless-testing
Signed-off-by: Abhijay Jain <[email protected]>
555bbc8
to
2a3fcf7
Compare
Signed-off-by: Abhijay Jain <[email protected]>
Signed-off-by: Abhijay Jain <[email protected]>
Signed-off-by: Abhijay Jain <[email protected]>
Signed-off-by: Abhijay Jain <[email protected]>
Signed-off-by: Abhijay Jain <[email protected]>
Signed-off-by: Abhijay Jain <[email protected]>
cc : @davepagurek , @satyasaibhushan review required. |
Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first |
Signed-off-by: Abhijay Jain <[email protected]>
Signed-off-by: Abhijay Jain <[email protected]>
@davepagurek 20 tests are falling in total : |
I will open a follow-up PR once we merge this one, commenting all those falling tests |
Signed-off-by: Abhijay Jain <[email protected]>
@Abhijay007 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you really want to open a new PR, you can cherry-pick the commits done my be in the original PR.
@satyasaibhushan I didn't have the access to resolve the conflicts directly that's why I opened a new PR resolving the existing one, and I was not aware of the cherry-pick commits technique before, thanks for mentioning that, I will iterate the PR accordingly. |
Signed-off-by: Abhijay Jain [email protected]
refer PR: #641 (resolved merge conflicts in existing PR)