Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor accessibility test #3328

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

khanniie
Copy link
Collaborator

@khanniie khanniie commented Jan 28, 2025

Fixes the editor accessibility issue that appears to happen on the develop branch:

 FAIL  client/modules/IDE/components/EditorAccessibility.unit.test.jsx
  ● <EditorAccessibility /> › renders empty message with no lines

    TestingLibraryElementError: Unable to find an accessible element with the role "listitem" and description "There are no lint messages"

Changes: The issue (not sure when it was first introduced) is that the "there are no lint messages" list item element does not have an aria-describedby attribute so the original method of fetching by role and description does not actually detect what it's looking for. This switches the test to look for the string instead.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com release-com bot deployed to p5.js-web-editor: fix-editor-accessibility-test-error (tedc5fb) January 28, 2025 06:19 Active
Copy link

release-com bot commented Jan 28, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-a55ba451c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants