Skip to content
Testing

Overhaul custom shapes for p5.js 2.0 #5154

Sign in to view logs

Overhaul custom shapes for p5.js 2.0

Overhaul custom shapes for p5.js 2.0 #5154

Triggered via pull request November 27, 2024 13:16
@GregStantonGregStanton
synchronize #7373
GregStanton:dev-2.0
Status Failure
Total duration 2m 34s
Artifacts –

ci-test.yml

on: pull_request
test
2m 25s
test
Fit to window
Zoom out
Zoom in

Annotations

10 errors
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > Immediate mode constructs are translated correctly: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ TriangleStrip.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:396:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.Geometry.js:236:18 ❯ assertGeometryRendersMatch test/unit/webgl/p5.Geometry.js:181:9 ❯ test/unit/webgl/p5.Geometry.js:215:7
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > freeGeometry() cleans up resources: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ QuadStrip.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:396:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ drawShape test/unit/webgl/p5.Geometry.js:280:14 ❯ RendererGL.buildGeometry src/webgl/p5.RendererGL.js:438:5 ❯ fn.buildGeometry src/webgl/3d_primitives.js:835:27 ❯ test/unit/webgl/p5.Geometry.js:286:25
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > QUADS mode converts into triangles: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ Quad.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:396:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1474:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > QUADS mode makes edges for quad outlines: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ Quad.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:396:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1596:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > QUAD_STRIP mode makes edges for strip outlines: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ QuadStrip.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:396:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1613:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TRIANGLE_FAN mode makes edges for each triangle: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ TriangleFan.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:396:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1635:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS preserves vertex data: src/shape/custom_shapes.js#L395
TypeError: primitiveShapeCreator is not a function ❯ Shape.vertex src/shape/custom_shapes.js:395:26 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1652:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS does not affect stroke colors: src/shape/custom_shapes.js#L395
TypeError: primitiveShapeCreator is not a function ❯ Shape.vertex src/shape/custom_shapes.js:395:26 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1754:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS does not affect texture coordinates: src/shape/custom_shapes.js#L395
TypeError: primitiveShapeCreator is not a function ❯ Shape.vertex src/shape/custom_shapes.js:395:26 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1780:12
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS interpolates vertex data at intersections: src/shape/custom_shapes.js#L395
TypeError: primitiveShapeCreator is not a function ❯ Shape.vertex src/shape/custom_shapes.js:395:26 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2043:20 ❯ test/unit/webgl/p5.RendererGL.js:1812:12