Overhaul custom shapes for p5.js 2.0 #5161
davepagurekAnnotations
10 errors
|
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > Immediate mode constructs are translated correctly:
src/webgl/3d_primitives.js#L2928
Error: vertex() must be used once before calling quadraticVertex()
❯ RendererGL.quadraticVertex src/webgl/3d_primitives.js:2928:13
❯ fn.quadraticVertex src/shape/vertex.js:1820:22
❯ test/unit/webgl/p5.Geometry.js:227:14
❯ assertGeometryRendersMatch test/unit/webgl/p5.Geometry.js:181:9
❯ test/unit/webgl/p5.Geometry.js:215:7
|
|
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > freeGeometry() cleans up resources:
src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented.
❯ get vertexCapacity src/shape/custom_shapes.js:54:11
❯ QuadStrip.addToShape src/shape/custom_shapes.js:78:39
❯ Shape.vertex src/shape/custom_shapes.js:407:20
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ drawShape test/unit/webgl/p5.Geometry.js:280:14
❯ RendererGL.buildGeometry src/webgl/p5.RendererGL.js:438:5
❯ fn.buildGeometry src/webgl/3d_primitives.js:835:27
❯ test/unit/webgl/p5.Geometry.js:286:25
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > contours match 2D:
src/shape/vertex.js#L1330
TypeError: Cannot read properties of undefined (reading 'slice')
❯ fn.endContour src/shape/vertex.js:1330:37
❯ getColors test/unit/webgl/p5.RendererGL.js:638:12
❯ test/unit/webgl/p5.RendererGL.js:644:22
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > QUADS mode converts into triangles:
src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented.
❯ get vertexCapacity src/shape/custom_shapes.js:54:11
❯ Quad.addToShape src/shape/custom_shapes.js:78:39
❯ Shape.vertex src/shape/custom_shapes.js:407:20
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1474:12
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > QUADS mode makes edges for quad outlines:
src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented.
❯ get vertexCapacity src/shape/custom_shapes.js:54:11
❯ Quad.addToShape src/shape/custom_shapes.js:78:39
❯ Shape.vertex src/shape/custom_shapes.js:407:20
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1596:12
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > QUAD_STRIP mode makes edges for strip outlines:
src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented.
❯ get vertexCapacity src/shape/custom_shapes.js:54:11
❯ QuadStrip.addToShape src/shape/custom_shapes.js:78:39
❯ Shape.vertex src/shape/custom_shapes.js:407:20
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1613:12
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TRIANGLE_FAN mode makes edges for each triangle:
src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented.
❯ get vertexCapacity src/shape/custom_shapes.js:54:11
❯ TriangleFan.addToShape src/shape/custom_shapes.js:78:39
❯ Shape.vertex src/shape/custom_shapes.js:407:20
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1635:12
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS preserves vertex data:
src/shape/custom_shapes.js#L406
TypeError: primitiveShapeCreator is not a function
❯ Shape.vertex src/shape/custom_shapes.js:406:26
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1652:12
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS does not affect stroke colors:
src/shape/custom_shapes.js#L406
TypeError: primitiveShapeCreator is not a function
❯ Shape.vertex src/shape/custom_shapes.js:406:26
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1754:12
|
|
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > beginShape() in WEBGL mode > TESS does not affect texture coordinates:
src/shape/custom_shapes.js#L406
TypeError: primitiveShapeCreator is not a function
❯ Shape.vertex src/shape/custom_shapes.js:406:26
❯ RendererGL.vertex src/core/p5.Renderer.js:137:23
❯ fn.vertex src/shape/vertex.js:2045:20
❯ test/unit/webgl/p5.RendererGL.js:1780:12
|