Skip to content

Overhaul custom shapes for p5.js 2.0 #5162

Overhaul custom shapes for p5.js 2.0

Overhaul custom shapes for p5.js 2.0 #5162

Triggered via pull request November 29, 2024 00:19
Status Failure
Total duration 2m 27s
Artifacts

ci-test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > get() > get() creates a p5.Image with 1x pixel density: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn.image src/image/loading_displaying.js:1133:20 ❯ test/unit/webgl/p5.Framebuffer.js:469:12
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > loadPixels works in arbitrary order for multiple framebuffers: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ Framebuffer.updatePixels src/webgl/p5.Framebuffer.js:1565:21 ❯ test/unit/webgl/p5.Framebuffer.js:510:12
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > Strokes work on and off of framebuffers: src/webgl/ShapeBuilder.js#L70
TypeError: Cannot read properties of null (reading 'array') ❯ ShapeBuilder.constructFromContours src/webgl/ShapeBuilder.js:70:56 ❯ RendererGL.drawShape src/webgl/p5.RendererGL.js:458:23 ❯ RendererGL.endShape src/core/p5.Renderer.js:109:10 ❯ RendererGL.endShape src/webgl/p5.RendererGL.js:475:11 ❯ fn.endShape src/shape/vertex.js:1517:20 ❯ drawCircle test/unit/webgl/p5.Framebuffer.js:543:12 ❯ Framebuffer.draw src/webgl/p5.Framebuffer.js:1271:5 ❯ test/unit/webgl/p5.Framebuffer.js:546:9
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > nesting > with antialiasing off > one can read a nested framebuffer: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn.image src/image/loading_displaying.js:1133:20 ❯ test/unit/webgl/p5.Framebuffer.js:602:16
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > nesting > with antialiasing on > one can read a nested framebuffer: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn.image src/image/loading_displaying.js:1133:20 ❯ test/unit/webgl/p5.Framebuffer.js:602:16
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > Immediate mode constructs are translated correctly: src/webgl/3d_primitives.js#L2928
Error: vertex() must be used once before calling quadraticVertex() ❯ RendererGL.quadraticVertex src/webgl/3d_primitives.js:2928:13 ❯ fn.quadraticVertex src/shape/vertex.js:1820:22 ❯ test/unit/webgl/p5.Geometry.js:227:14 ❯ assertGeometryRendersMatch test/unit/webgl/p5.Geometry.js:181:9 ❯ test/unit/webgl/p5.Geometry.js:215:7
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > freeGeometry() cleans up resources: src/shape/custom_shapes.js#L54
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:54:11 ❯ QuadStrip.addToShape src/shape/custom_shapes.js:78:39 ❯ Shape.vertex src/shape/custom_shapes.js:407:20 ❯ RendererGL.vertex src/core/p5.Renderer.js:137:23 ❯ fn.vertex src/shape/vertex.js:2045:20 ❯ drawShape test/unit/webgl/p5.Geometry.js:280:14 ❯ RendererGL.buildGeometry src/webgl/p5.RendererGL.js:440:5 ❯ fn.buildGeometry src/webgl/3d_primitives.js:835:27 ❯ test/unit/webgl/p5.Geometry.js:286:25
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > filter shader > custom shaders > work with a 2D main canvas: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn._copyHelper src/image/pixels.js:412:26 ❯ fn.copy src/image/pixels.js:382:8 ❯ fn.filter src/image/pixels.js:758:27 ❯ testFilterShader test/unit/webgl/p5.RendererGL.js:239:16 ❯ test/unit/webgl/p5.RendererGL.js:249:9
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > filter shader > custom shaders > work with a WebGL main canvas: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ RendererGL.filter src/webgl/p5.RendererGL.js:1197:10 ❯ fn.filter src/image/pixels.js:730:22 ❯ testFilterShader test/unit/webgl/p5.RendererGL.js:239:16 ❯ test/unit/webgl/p5.RendererGL.js:254:9
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > filter shader > custom shaders > work with a 2D graphic: src/webgl/ShapeBuilder.js#L443
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:443:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:334:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:119:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:488:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn._copyHelper src/image/pixels.js:412:26 ❯ fn.copy src/image/pixels.js:382:8 ❯ fn.filter src/image/pixels.js:758:27 ❯ testFilterShader test/unit/webgl/p5.RendererGL.js:239:16 ❯ test/unit/webgl/p5.RendererGL.js:260:9