docs/httpDo #2164
Merged
docs/httpDo #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: austin <[email protected]>
Signed-off-by: austin <[email protected]>
Signed-off-by: austin <[email protected]>
Signed-off-by: austin <[email protected]>
lmccart
requested changes
Sep 14, 2017
src/io/files.js
Outdated
| * var url = 'https://earthquake.usgs.gov/fdsnws/event/1/query?format=geojson'; | ||
| * httpDo(url, | ||
| * { | ||
| * method: 'GET', // http method - "GET", "PUT", "POST", etc. |
There was a problem hiding this comment.
let's omit this comment for readability, since this info is mentioned in the parameters already
There was a problem hiding this comment.
Just the method comment or the Request options one as well?
There was a problem hiding this comment.
I think the other one is fine to leave, since those options may be less clear
Signed-off-by: austin <[email protected]>
lmccart
approved these changes
Sep 18, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on documentation from this issue: #1954
Only added one example, using the
Requestoptions, but did something more creative with the data. Could do an example ofPUTbut I feel like it's better to let users get nifty with it.Using the same earthquake data api as used in the
httpGetexample;