Add example for p5.Table.getArray() #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/io/p5.Table.js
Outdated
| @@ -1213,6 +1213,32 @@ p5.Table.prototype.getObject = function(headerColumn) { | |||
| * | |||
| * @method getArray | |||
| * @return {Array} | |||
| * @example | |||
| * <div class="no render"> | |||
There was a problem hiding this comment.
There shouldn't be a space between "no" and "render" otherwise they are actually two classes .no and .render instead of one class .norender.
src/io/p5.Table.js
Outdated
| @@ -1107,7 +1107,7 @@ p5.Table.prototype.getNum = function(row, column) { | |||
| * @return {String} | |||
| * | |||
| * @example | |||
| * <div class="norender"> | |||
| * <div> | |||
There was a problem hiding this comment.
If the norender class is not present, the sketch will still create a canvas but it would be empty in this particular case since nothing will be drawn on screen. Can be a bit confusing I think since most people won't have the console opened all the time.
|
Thanks! Left a couple of comments, do have a look. |
|
@limzykenneth thanks for your correction. I already fix it |
|
thanks @seagalputra and @limzykenneth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, all
This is my first contribution in here.
Recently, i read an issue here #1954. So, i add a simple code for method getArray()
Thank you