Fixed error in references #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
Hi @aLyonsGH, I think you have accidentally saved the edited file as a new file at the root of the project folder instead of saving over the original file. Can you try can revert the current changes and save the changes in the original file? Thanks. |
Fixed file accidentally added to root, now fix is added here on line 364
Oops! Moved the change to the proper file location.
|
Done! I think this is all set now? Thank you for your patience, this is my first contribution to p5.js! |
|
I'm not sure why the CI tests are not running, they keep getting cancelled after starting for a few minutes. @outofambit Do you have an idea what's going on? |
outofambit
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2865
In the description of lerpColor(), I changed "the two values where 0.0 equal to the first color" to "the two values where 0.0 is equal to the first color" (I added the "is")