Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand keyIsDown() to work with characters as arguments #6983

Closed
wants to merge 5 commits into from

Conversation

wwwld1
Copy link

@wwwld1 wwwld1 commented Apr 20, 2024

Resolves #6798

Changes:

This is a working draft of this issue #6798 which allows for keyIsDown() to accept alphanumeric String params such as 'w' or 'W'. Regarding the confusing case of the int 4 versus string '4', this implementation includes both where the string parameter e.g. '4' reflects the ASCII value of '4' while the int parameter e.g. 4 reflects the ASCII code 4.

The documentation is also updated to reflect the changes with examples now included for the new changes.

Screenshots of the change:

image

PR Checklist

Copy link

welcome bot commented Apr 20, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@limzykenneth
Copy link
Member

Hi @wwwld1, we are currently not looking for implementation of any of the 2.0 related proposals as they still need to be agreed upon and approved before we organize their implementation. There are also things that needed to be discussed for each proposals in detail before implementation should start.

If you wish to submit a proof of concept, you can work against the dev-2.0 branch instead of the main branch. Thanks.

@wwwld1
Copy link
Author

wwwld1 commented Apr 26, 2024

Hi @wwwld1, we are currently not looking for implementation of any of the 2.0 related proposals as they still need to be agreed upon and approved before we organize their implementation. There are also things that needed to be discussed for each proposals in detail before implementation should start.

If you wish to submit a proof of concept, you can work against the dev-2.0 branch instead of the main branch. Thanks.

Hi @limzykenneth , thank you! I just made another PR over dev-2.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[p5.js 2.0 RFC Proposal]: expand keyIsDown() to work with characters as arguments
4 participants