[p5.js 2.0] IO refactoring #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of p5.Table is very broken and loadTable was also very broken. This commit does not fix the implementation fully as it still need to be decided whether p5.Table is to be retained. The fact that no one has noticed p5.Table and loadTable is so broken might be a good reason to not retain them as no one is using them.
|
Nice work, the loading implementations look clean! Using the worker to mock responses in tests is a cool approach. |
|
@davepagurek Yeah, that gives us more flexibility but for now is mainly to solve vitest itself not able to respond with 404 properly. I'm not doing too much test fixing just yet though, for now want to refactor the new implementation and maybe look into the file saving aspect. Tests I'll do after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a rewrite of the IO functions starting with the loading functions and will move to the saving functions later.
The main goal is to utilize promises and the
fetchAPI as much as possible while exposing a reasonable public interface for the user. The overloads will also be simplified in favor of defaults and for more advanced users who wishes for more customized functionalities to pass inRequestobject instead.