Added ability to use setUniform for textures by texture slot rather than by p5.Texture #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han by p5.Texture
|
If the stewards would be ok with it, I could also use this same system to quickly add support for other SAMPLER types shown here |
davepagurek
reviewed
Nov 27, 2024
…a non-WebGL-constant number is used
davepagurek
reviewed
Dec 1, 2024
davepagurek
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7394
Changes:
Adds the option to use
setUniformby texture slot instead of by p5.Texture.PR Checklist
npm run lintpasses