Skip to content

Fix _isgloabl flag in ini method #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VANSH3104
Copy link
Contributor

Resolves #7781

Changes:

  • Moved the _isGlobal assignment earlier in the p5 constructor to ensure it is correctly set
  • Fixed _isGlobal flag in init methods by replacing direct init method calls with callRegisteredHooksFor('init') to ensure proper context is set based on _isGlobal flag.
  • This ensures that registered "init" methods correctly receive the global mode status, which is crucial for addons and libraries that rely on this flag.

Screenshots of the change:

PR Checklist

@quinton-ashley
Copy link
Contributor

Looks good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_isGlobal is false when it should be true
2 participants